ios - Refactor a switch statement with cyclomatic complexity upper than 10 -


i've code:

for notif in environmentmanager.notif {     if let type = notif.type {             switch type {             case .sitteravailable:                 self.managenotif(notif, title: "une sitter disponible", storyboardname: "searchguard", vcname: "searchguardncsid")             case .occasionaladjustmentreminder:                 self.managenotif(notif, title: "rappel", storyboardname: "searchguard", vcname: "searchguardncsid")             case .guardrequest:                 self.managenotif(notif, title: "nouvelle garde urgente", storyboardname: "emergencyguardsitter", vcname: "emergencyguardsitternavigationcontrollersid")             case .newreservationrequest:                 self.managenotif(notif, title: "nouvelle garde", storyboardname: "guardwebsitter", vcname: "webguardsitternavigationcontrollersid")             case .newmessage:                 self.managenotif(notif, title: "nouveau message", storyboardname: "messagelistsitter", vcname: "messagesitterviewnavigationcontrollersid")             case .soonreservationstartreminder:                 self.managenotif(notif, title: "rappel", storyboardname: "guardlistsitter", vcname: "guardlistsitternavigationcontrollersid")             case .reservationaccepted:                 self.managenotif(notif, title: "garde acceptée", storyboardname: "guardlistsitter", vcname: "guardlistsitternavigationcontrollersid")             case .reservationrefused:                 self.managenotif(notif, title: "garde refusée", storyboardname: "guardlistsitter", vcname: "guardlistsitternavigationcontrollersid")             case .newmessageparent:                 self.managenotif(notif, title: "nouveau message", storyboardname: "messageparent", vcname: "messageparentviewnavigationcontrollersid")             }         }     }

i want know how optimize counter cyclomatic complexity this, without array of string or that,

currently complexity equals 11

thanks help

an array of simple structure containing title, storyboardname , vcname solve neatly.

if type ordered 0..10, can use index array. if type doesn't run 0..10, include in structure, , first find index need.

define structure 

struct notificationtypedata {     var notificationtype    : int    = 0     var title               : string = ""     var storyboardname      : string = ""     var vcname              : string = "" }

and set variable hold it

var notificationtypedata : [notificationtypedata]?

you need populate - file, or hard-coded. here first few...

notificationtypedata!.append(notificationtypedata(notificationtype: 0, title: "une sitter disponible", storyboardname: "searchguard", vcname: "searchguardncsid")) notificationtypedata!.append(notificationtypedata(notificationtype: 1, title: "rappel", storyboardname: "emergencyguardsitter", vcname: "emergencyguardsitternavigationcontrollersid")) notificationtypedata!.append(notificationtypedata(notificationtype: 2, title: "nouvelle garde urgente", storyboardname: "guardwebsitter", vcname: "webguardsitternavigationcontrollersid")) notificationtypedata!.append(notificationtypedata(notificationtype: 3, title: "nouvelle garde", storyboardname: "messagelistsitter", vcname: "messagesitterviewnavigationcontrollersid")) notificationtypedata!.append(notificationtypedata(notificationtype: 4, title: "nouveau message", storyboardname: "guardlistsitter", vcname: "guardlistsitternavigationcontrollersid"))

and simplify switch code have

for notif in environmentmanager.notif {     if let type = notif.type     {          switch type          {              let data = notificationtypedata!.filter{ $0.notificationtype == type }.first              if data != nil              {                  self.managenotif(notif, title: data?.title, storyboardname: data?.storyboardname, vcname: data?.storyboardname              }          }      }

-

Comments

Post a Comment

Popular posts from this blog

serialization - Convert Any type in scala to Array[Byte] and back -

i have following question: i have variable value in program declared value. i want convert value byte array.. how can serialize byte array , back? found examples related other types such double or int, not any. this should need. it's pretty similar how 1 in java. import java.io.{bytearrayinputstream, bytearrayoutputstream, objectinputstream, objectoutputstream} object serialization extends app { def serialise(value: any): array[byte] = { val stream: bytearrayoutputstream = new bytearrayoutputstream() val oos = new objectoutputstream(stream) oos.writeobject(value) oos.close stream.tobytearray } def deserialise(bytes: array[byte]): = { val ois = new objectinputstream(new bytearrayinputstream(bytes)) val value = ois.readobject ois.close value } println(deserialise(serialise("my test"))) println(deserialise(serialise(list(1)))) println(deserialise(serialise(map(1 -> 2)))) println(deserialise(seri
Read more

matplotlib support failed in PyCharm on OSX -

any idea how fix ? how can debug might problem ? not seem : https://youtrack.jetbrains.com/issue/py-15520 i in console: python 2.6.9 (unknown, jul 14 2015, 19:46:31) [gcc 4.2.1 compatible apple llvm 6.0 (clang-600.0.39)] on darwin >>> import matplotlib.pyplot plt matplotlib support failed the backend : >>> import matplotlib >>> print(matplotlib.rcparams['backend']) macosx
Read more

python - Matplotlib: TypeError: 'AxesSubplot' object is not callable -

i new programming please pardon me if rookie mistake. i writing python script have defined functions create subplots of distributions. i have slider widget end user change value of variables(mu , sigma) , see effect on distribution. here's code import numpy np print np.__version__ import scipy print scipy.__version__ scipy.stats import norm, lognorm, uniform import matplotlib print matplotlib.__version__ import matplotlib.pyplot plt matplotlib.widgets import slider, button, radiobuttons, checkbuttons #####calculating mean , standard deviation##### global mu_a1 mu_a1 = 1 global mu_b1 mu_b1 = 10 global mu_c1 mu_c1 = -13 global sigma_a1 sigma_a1 = 0.14 global sigma_b1 sigma_b1 = 1.16 global sigma_c1 sigma_c1 = 2.87 mu_x01 = -11 sigma_x01 = 1.9 #####_____##### #####generating random data##### a1 = 0.75*mu_a1 + (1.25 - 0.75)*sigma_a1*np.random.sample(10000) b1 = 8*mu_b1 + (12 - 8)*sigma_b1*np.random.sample(10000) c1 = -12*mu_c1 + 2*sigma_c1*np.random.sample(10000)
Read more